Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to latest Ruma version #4532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Jan 14, 2025

Extracted from #4531.

This patch updates ruma to the latest commit at the time of writing.

I'm really not sure about what I'm doing, so please be careful during the review 😛.

@Hywan Hywan requested review from a team as code owners January 14, 2025 15:44
@Hywan Hywan requested review from bnjbvr and richvdh and removed request for a team January 14, 2025 15:44
@Hywan Hywan force-pushed the chore-update-ruma branch from cb8d562 to 7c6a592 Compare January 14, 2025 15:48
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (9641aa9) to head (7c6a592).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4532      +/-   ##
==========================================
- Coverage   85.43%   85.42%   -0.02%     
==========================================
  Files         285      285              
  Lines       32105    32064      -41     
==========================================
- Hits        27429    27390      -39     
+ Misses       4676     4674       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar
Copy link
Contributor

poljar commented Jan 14, 2025

This patch updates ruma to the latest commit at the time of writing.

Latest commit on the stable branch of Ruma or on the main branch? The main branch won't see a release in the next 6ish months.

The Ruma folks very nicely provide a stable branch on which they backport non-breaking changes: https://github.com/ruma/ruma/tree/ruma-0.12.

What exactly do you need from the Ruma bump?

@richvdh
Copy link
Member

richvdh commented Jan 14, 2025

I feel like this probably wants a changelog entry or two, assuming that the ruma changes result in some externally-visible change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants