Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeline): Add UTDs to the timeline conditionally #4525

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jmartinesp
Copy link
Contributor

Should fix element-hq/element-x-ios#3669.

Take into account the should_add parameter for including UTDs in the timeline, as is done for other types of events.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner January 13, 2025 16:33
@jmartinesp jmartinesp requested review from Hywan and removed request for a team January 13, 2025 16:33
@jmartinesp jmartinesp force-pushed the fix/utds-added-to-every-timeline branch from 86fdda4 to 58b34a6 Compare January 13, 2025 16:40
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (5548f38) to head (153f9e7).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4525      +/-   ##
==========================================
- Coverage   85.38%   85.37%   -0.01%     
==========================================
  Files         285      285              
  Lines       31961    31962       +1     
==========================================
- Hits        27290    27288       -2     
- Misses       4671     4674       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp force-pushed the fix/utds-added-to-every-timeline branch from 58b34a6 to 153f9e7 Compare January 13, 2025 16:55
@jmartinesp jmartinesp changed the title feat(timeline): Add UTDs to the timeline conditionally fix(timeline): Add UTDs to the timeline conditionally Jan 13, 2025
@jmartinesp
Copy link
Contributor Author

jmartinesp commented Jan 14, 2025

The test matrix_sdk_integration_testing::tests::sliding_sync::room::test_delayed_invite_response_and_sent_message_decryption seems to be consistently failing here because the timeline doesn't contain any event, although the only actual code change in this PR is the if should_add check and I've confirmed with a debugger that it's true, so it should behave just as before 🫤 .

EDIT: oops this is failing on main too 😬 .

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jmartinesp jmartinesp merged commit e9487b0 into main Jan 14, 2025
40 checks passed
@jmartinesp jmartinesp deleted the fix/utds-added-to-every-timeline branch January 14, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXI wrongly pin every messages of a DM the first time it is opened
2 participants