Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event cache): remove events when forgetting a room #4521

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jan 13, 2025

Does what it says on the tin, and fixes a bug where clearing a room in the in-memory linked chunk would clear all rooms at once.

Part of #3280.

@bnjbvr bnjbvr requested a review from a team as a code owner January 13, 2025 14:14
@bnjbvr bnjbvr requested review from jmartinesp and removed request for a team January 13, 2025 14:14
@bnjbvr bnjbvr mentioned this pull request Jan 13, 2025
37 tasks
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (5548f38) to head (48df627).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4521   +/-   ##
=======================================
  Coverage   85.38%   85.39%           
=======================================
  Files         285      285           
  Lines       31961    31993   +32     
=======================================
+ Hits        27290    27320   +30     
- Misses       4671     4673    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bnjbvr bnjbvr merged commit a8ca77f into main Jan 13, 2025
40 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/remove-cached-room-events branch January 13, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants