Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Expose Client::server_versions publicly #4519

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Jan 12, 2025

We have one specific use case at the moment for this in Fractal, to build the UIAA fallback URL depending on the Matrix version. Currently we always use the r0 version that is hardcoded in our code.

But I also don't see why it should not be public.

  • Public API changes documented in changelogs (optional)

@zecakeh zecakeh requested a review from a team as a code owner January 12, 2025 19:42
@zecakeh zecakeh requested review from bnjbvr and removed request for a team January 12, 2025 19:42
Signed-off-by: Kévin Commaille <[email protected]>
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (e37ad11) to head (83f53a8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4519      +/-   ##
==========================================
+ Coverage   85.36%   85.39%   +0.03%     
==========================================
  Files         284      284              
  Lines       31886    31886              
==========================================
+ Hits        27219    27229      +10     
+ Misses       4667     4657      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, indeed should be public.

@poljar poljar merged commit ca9eb70 into matrix-org:main Jan 13, 2025
40 checks passed
@zecakeh zecakeh deleted the expose-server-versions branch January 13, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants