-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(room): add methods to customise a Room's privacy settings #4401
Changes from all commits
31a1f11
7a4ed4f
4a89766
4697037
83acb33
ca2a7c4
1ec3b26
0d97aac
233036a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -155,6 +155,12 @@ impl From<RoomSendQueueError> for ClientError { | |
} | ||
} | ||
|
||
impl From<NotYetImplemented> for ClientError { | ||
fn from(_: NotYetImplemented) -> Self { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we're starting to use that more and more, I wonder if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good, but as you suggest I'd rather make this change in a new PR. |
||
Self::new("This functionality is not implemented yet.") | ||
} | ||
} | ||
|
||
/// Bindings version of the sdk type replacing OwnedUserId/DeviceIds with simple | ||
/// String. | ||
/// | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just moved to a different file, to have the functions grouped.