Skip to content

Commit

Permalink
chore(xtask): tweak the TWiM report to include only merged PRs, not c…
Browse files Browse the repository at this point in the history
…reated PRs

As an outsider, I am mostly interested in features and new developments
that have happened, not those that *may* happen. An open-but-not-merged
PR may not get merged in the end, or it may not get merged any time
soon, creating false expectations. Merged PRs, on the other hand, have
definitely happened (even if they get undone, that happens via other PRs
that will get merged later). As such, I think it brings more value to
outsiders.
  • Loading branch information
bnjbvr committed Jan 13, 2025
1 parent ca9eb70 commit c9a4900
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xtask/src/release.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ fn weekly_report() -> Result<()> {

cmd!(
sh,
"gh pr list --search created:>{one_week_ago} --json {JSON_FIELDS} --template {template}"
"gh pr list --search merged:>{one_week_ago} --json {JSON_FIELDS} --template {template}"
)
.quiet()
.run()?;
Expand Down

0 comments on commit c9a4900

Please sign in to comment.