Fix ToDeviceRequest conversion #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Oct 18, 2023
richvdh
approved these changes
Oct 18, 2023
Comment on lines
+194
to
+196
| /// Some signature upload will have to an `id` field, some won't. | ||
| /// They have one when they are created automatically during an interactive | ||
| /// verification, otherwise they don't. |
Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#26382
When used in WebR,
olmMachine.shareRoomKey()was always returning ToDeviceRequest without id (undefined).As a consequence markRequestAsSent was never called, and room keys were re-shared for each message.
I tried to clarify in bindings when there should be a
request_id. So I replaced a most of thepub id: Option<JsString>,withpub id: JsString,.The conversion methods have been updated also.