feat(room_key_stream): Add support for lagging stream error #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
approved these changes
Dec 20, 2024
| /// `error_callback` should be a function that takes a single argument (the | ||
| /// error) and returns a Promise. When such an error happens that means | ||
| /// that update stream lost track and that all current decryption failures | ||
| /// can be retried as the key might as been imported without notice. |
There was a problem hiding this comment.
Suggested change
| /// can be retried as the key might as been imported without notice. | |
| /// should be retried as the key may have been imported without notice. |
| @@ -929,6 +929,22 @@ describe(OlmMachine.name, () => { | |||
| expect(keyInfoList.length).toEqual(1); | |||
| expect(keyInfoList[0].roomId.toString()).toStrictEqual(room.toString()); | |||
| }); | |||
|
|
|||
| test("importing room keys calls RoomKeyUpdatedCallbacks", async () => { | |||
There was a problem hiding this comment.
We also need a test of the error case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.