Use asynchronous wasm instantiation methods where possible #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Will do, but you need to fix the CI for it first ;) |
|
I've merged #176, I merged back main on this PR fixing the conflicts |
richvdh
commented
Dec 10, 2024
| instance.exports.__wbindgen_start(); | ||
| initialised = true; | ||
| return instance.exports; |
There was a problem hiding this comment.
I was rather thinking that returning this here would reduce the number of @ts-expect-errors we needed, but 🤷
sandhose
approved these changes
Dec 10, 2024
... because I keep getting confused
Currently, every call to `loadModuleSync` or `loadModuleAsync` in the node entry points has to be followed by a call to `initInstance`. This change moves that call into `loadModule[A]sync` instead. This (a) brings the node code more into line with the browser code; (b) lays groundwork for the future where I want to move bits of `initInstance` into `loadModule[A]sync`.
This fixes a problem on Chrome, which would complain about the module being too big. It also significantly simplifies the code on the browser entry points, because `instantiateStreaming` is widely supported.
richvdh
force-pushed
the
rav/async_instantiate
branch
from
9c45cdf to
91ae6a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem (introduced in #167) on Chrome, which would complain about the module being too big. It also significantly simplifies the code on the browser entry points, because
instantiateStreamingis widely supported.