Skip to content

Commit

Permalink
Stop deleting build results during rebuilds (#175)
Browse files Browse the repository at this point in the history
This solves a problem with the webpack-dev-server, which would see the
half-built javascript output and explode with a big error about `Can't resolve
'./pkg/matrix_sdk_crypto_wasm_bg.js'`
  • Loading branch information
richvdh authored Dec 5, 2024
1 parent db1af39 commit 2313de1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
- The published package is now a proper dual CommonJS/ESM package.
- The WebAssembly module is now loaded using `fetch` on Web platforms, reducing
the bundle size significantly, as well as the time it takes to compile it.
([#167](https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/pull/167))
([#167](https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/pull/167)),
([#175](https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/pull/175))

**BREAKING CHANGES**

Expand Down
2 changes: 0 additions & 2 deletions scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ cd "$(dirname "$0")"/..

WASM_PACK_ARGS="${WASM_PACK_ARGS:-}"

rm -rf pkg

# Generate the JavaScript bindings
# --no-pack disables generation of a `package.json` file, as we're managing it ourselves.
wasm-pack build --no-pack --target bundler --scope matrix-org --out-dir pkg --weak-refs "${WASM_PACK_ARGS}"
Expand Down

0 comments on commit 2313de1

Please sign in to comment.