This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add persistence of collapsed state of space panel #9245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gefgu <[email protected]>
github-actions
bot
added
Z-Community-PR
turt2live
suggested changes
Sep 7, 2022
gefgu
force-pushed
the
persist-minimised-space-panel
branch
from
3f5290c to
50f1a55
Compare
|
I've added the cypress test and would be delighted if you could review it - It is the first time I work with cypress :). Also, I've removed the try/catch block. It does not seems to be necessary. |
gefgu
requested review from
turt2live
and removed request for
dbkr,
t3chguy and
kerryarchibald
turt2live
reviewed
Sep 10, 2022
…ix-react-sdk into persist-minimised-space-panel
turt2live
requested review from
turt2live
and removed request for
turt2live
turt2live
reviewed
Sep 21, 2022
| cy.get(".mx_SpacePanel_toggleCollapse").click(); | ||
| cy.get(".mx_SpacePanel").should("not.have.class", "collapsed"); | ||
| cy.reload(true); | ||
| cy.get(".mx_SpacePanel").should("not.have.class", "collapsed"); |
There was a problem hiding this comment.
we should also probably check to see if clicking it again and reloading causes it to un-collapse
…ix-react-sdk into persist-minimised-space-panel
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gefgu [email protected]
Checklist
Notes: Add persistence of collapsed state of space panel. It fixes element-hq/element-web#23172
Type: enhancement
Behavior: (Hard reload was made by
ctrl + shift + r)space-panel-demonstration_2xspeed.mp4
This change was made using LocalStorage implemented inside of the component. I'm not sure it's the best solution because of most of the other LocalStorage values are implemented using stores. In this way, I want feedback about my approach and I'm willing to keep working on this issue until it is resolved.
Here's what your changelog entry will look like:
✨ Features