-
-
Notifications
You must be signed in to change notification settings - Fork 827
Correct text alignment in RTL languages #9026
Conversation
Though I don't find a regression, I think it would be better to merge this PR after some feedback comments are provided from native RTL language speakers. I've posted a link to the netlify build on #5453 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've had massive issues with this sort of change in the past - I'd very much like to see screenshot tests of the timeline using various sample messages to ensure we didn't break anything.
#element-dev:matrix.org will likely be best to talk more about those sorts of tests.
res/css/views/rooms/_EventTile.scss
Outdated
ol, | ||
ul { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add comments for what this is targeting - it's not immediately obvious what the ol
and ul
actually are.
This comment was marked as outdated.
This comment was marked as outdated.
converting to draft for now- looking for a way of implementing visual tests. |
after the weekend the team should be able to help with tests in https://matrix.to/#/#element-dev:matrix.org |
- Apply logical properties for ol, ul, and blockquote Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Closed as RTL design will never land at least until Element X |
For element-hq/element-web#14520 and element-hq/element-web#4771
This PR intends to relieve frustration of RTL language users.
cf. #5453
Please mind the position of
(edited)
.cf. #5453 (comment)
I modified the declarations for
blockquote
,ul
, andol
to apply logical properties. Since I am not able to read RTL languages, it is not really possible for me to test edge cases though.The ideal solution would be to implement logical properties all over the UI, but the task is too large for this PR. Therefore adjusting position of UI elements such as timestamp is out of scope.
type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes