This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix style inconsistencies of "Verify this device" dialog #8167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
T-Defect
Codecov Report
@@ Coverage Diff @@
## develop #8167 +/- ##
========================================
Coverage 29.25% 29.25%
========================================
Files 863 863
Lines 49876 49876
Branches 12696 12696
========================================
Hits 14592 14592
Misses 35284 35284
|
Addresses element-hq/element-web#21572 Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
|
@luixxiul, could you please use |
|
No problem. Considering how much change this PR should include, I've replaced "fixes" with "addresses". |
luixxiul
changed the title
Signed-off-by: Suguru Hirahara <[email protected]>
- Nesting Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
luixxiul
changed the title
luixxiul
commented
Apr 1, 2022
| @@ -18,4 +18,5 @@ limitations under the License. | |||
| @mixin ButtonResetWarning; | |||
| color: $light-fg-color; // .mx_Dialog on _common.scss | |||
| margin-top: $font-14px; | |||
| line-height: 1; // align the warning icon | |||
There was a problem hiding this comment.
This change should fix this bug:
|
There is another dialog whose styles are also inconsistent due to the fact it uses
Here the color of the warning icon is black. |
|
Since it looks like it needs complicated changes of |
turt2live
reviewed
Apr 4, 2022
|
Closing as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#21572
This PR addresses style inconsistencies of the security key dialog and modal window, including
Signed-off-by: Suguru Hirahara [email protected]
Before
Current design
Image 1
Image 2
After
Perhaps the big red icon on the header should be replaced with something else.
type: defect
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://pr8167--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.