This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
SlidingSync does not work when hosted on path other than / (root) #12658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sliding-sync is hostet on the same domain, but in a sub path, the url resolution will fail.
Example:
base domain: matrix.example.com
sliding-sync: matrix.example.com/sliding-sync
the URL constructur
new URL("/client/server.json", proxyUrl)
will create the url matrix.example.com/client/server.json and not as required matrix.example.com/sliding-sync/client/server.json.Removing the leading slash from the will solve the issue as per the documentation https://developer.mozilla.org/en-US/docs/Web/API/URL/URL