This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Tooltip: Use RovingAccessibleButton instead of RovingAccessibleTooltipButton
#12539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Task
florianduros
force-pushed
the
florianduros/tooltip/RovingAccessibleTooltipButton
branch
from
763b0e4
to
1e3d61f
Compare
florianduros
force-pushed
the
florianduros/tooltip/RovingAccessibleTooltipButton
branch
from
1e3d61f
to
3aed90f
Compare
…essibleTooltipButton # Conflicts: # src/components/views/elements/AccessibleButton.tsx
richvdh
approved these changes
May 17, 2024
florianduros
deleted the
florianduros/tooltip/RovingAccessibleTooltipButton
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of element-hq/element-web#26762
RovingAccessibleTooltipButtonwas migrated to useAccessibleButtoninstead ofAccessibleTooltipButtonin a previous PR. There is no differences anymore betweenRovingAccessibleTooltipButtonandRovingAccessibleButton.So let's keep one.