This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Stop displaying verification done messages in timeline #11932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#26450 (the other part is #11931)
As agreed in element-hq/element-web#26258 (comment) :
Never display the verification conclusion in the timeline.
Instead of trying to be clever and show the status of verification in the timeline, just be really simple and only show the fact that a verification was requested. The actual verification can take place in the other parts of the UI that are designed for this purpose.
Here's what your changelog entry will look like:
🐛 Bug Fixes