Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Stop displaying verification done messages in timeline #11932

Merged

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Nov 24, 2023

Part of element-hq/element-web#26450 (the other part is #11931)

As agreed in element-hq/element-web#26258 (comment) :

UX should only show a tile for m.key.verification.request event type, without any info about the outcome (user can just check the profile to get verification state), just who requested, and ignore other events related to that verification.

Never display the verification conclusion in the timeline.

Instead of trying to be clever and show the status of verification in the timeline, just be really simple and only show the fact that a verification was requested. The actual verification can take place in the other parts of the UI that are designed for this purpose.


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Stop displaying verification done messages in timeline (#11932). Contributed by @andybalaam.

@andybalaam andybalaam requested a review from a team as a code owner November 24, 2023 16:20
@andybalaam andybalaam added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 24, 2023
@t3chguy
Copy link
Member

t3chguy commented Nov 24, 2023

As agreed in element-hq/element-web#26258 (comment) :

That comment is a proposal rather than an agreement from P/D?

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending whether P/D is on board with this

@robintown robintown removed the request for review from kerryarchibald November 29, 2023 22:52
@andybalaam andybalaam requested a review from pmaier1 November 30, 2023 14:17
Copy link

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andybalaam andybalaam added this pull request to the merge queue Dec 1, 2023
Merged via the queue into develop with commit 9269073 Dec 1, 2023
20 checks passed
@andybalaam andybalaam deleted the andybalaam/dont-display-verification-conclusions branch December 1, 2023 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants