Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Skip redaction tests that are still flaking #11704

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Oct 3, 2023

Skip all the other tests that flake for me locally.

Fixes element-hq/element-web#26221


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 3, 2023
@andybalaam andybalaam force-pushed the andybalaam/more-redaction-flakes branch from 29f7ed1 to 090c5b3 Compare October 3, 2023 14:42
@andybalaam andybalaam marked this pull request as ready for review October 3, 2023 14:43
@andybalaam andybalaam requested a review from a team as a code owner October 3, 2023 14:43
@andybalaam andybalaam requested review from dbkr and florianduros and removed request for a team October 3, 2023 14:43
Base automatically changed from andybalaam/fix-flake-in-redactions to develop October 3, 2023 17:03
@richvdh
Copy link
Member

richvdh commented Oct 3, 2023

Fixes element-hq/element-web#26264 too I think.

But not element-hq/element-web#26160 ? Though maybe that is fixed?

@richvdh richvdh added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@richvdh
Copy link
Member

richvdh commented Oct 3, 2023

image

SIGH. Alanis Morissette called. She wants her tests back.

@richvdh richvdh added this pull request to the merge queue Oct 3, 2023
Merged via the queue into develop with commit 1150779 Oct 3, 2023
20 checks passed
@richvdh richvdh deleted the andybalaam/more-redaction-flakes branch October 3, 2023 21:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
3 participants