This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
OIDC: extract token persistence functions to utils #11690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryarchibald
added
the
T-Task
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // store the access token unencrypted since localStorage only saves | ||
| // strings. | ||
| if (!!token) { | ||
| localStorage.setItem(storageKey, token); |
Check failure
Code scanning / CodeQL
Clear text storage of sensitive information
| await StorageManager.idbSave("account", storageKey, token); | ||
| } catch (e) { | ||
| if (!!token) { | ||
| localStorage.setItem(storageKey, token); |
Check failure
Code scanning / CodeQL
Clear text storage of sensitive information
t3chguy
approved these changes
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#25839
Extract token persistence functions from
Lifecycletoutils/tokens, so they can be used in OIDC utils without causing circular dependencies.Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.