Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tests for redactions in the main timeline #11587

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Tests for redactions in the main timeline #11587

merged 1 commit into from
Sep 8, 2023

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Sep 8, 2023 •
edited by github-actions bot
Loading

Part of element-hq/element-web#25449

This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 8, 2023
@andybalaam
Copy link
Contributor Author

Tests failed because of flaky test: element-hq/element-web#26138

@andybalaam andybalaam marked this pull request as ready for review September 8, 2023 03:22
@andybalaam andybalaam requested a review from a team as a code owner September 8, 2023 03:22
@andybalaam andybalaam added this pull request to the merge queue Sep 8, 2023
dbkr
dbkr approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still having a bit of allergic reaction to the cy.wait but in this case I'm struggling to come up with a better alternative.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2023
@andybalaam
Copy link
Contributor Author

Still having a bit of allergic reaction to the cy.wait but in this case I'm struggling to come up with a better alternative.

Yeah, me too :-(

@andybalaam andybalaam added this pull request to the merge queue Sep 8, 2023
Merged via the queue into develop with commit 728a3a7 Sep 8, 2023
85 checks passed
@andybalaam andybalaam deleted the andybalaam/tests-for-redactions branch September 8, 2023 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybalaam @dbkr