Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Simplify registration with email validation #11398

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Simplify registration with email validation #11398

merged 12 commits into from
Aug 15, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 11, 2023 •
edited by github-actions bot
Loading

Instead of having the email validation flow redirect back to the client which is error-prone due to 2 clients racing on the /register request we only encourage a single tab of Element (the one you started registering on) as this fixes both the flakiness and the double-registration.

Requires element-hq/element-web#25953
Fixes element-hq/element-web#25832
Fixes element-hq/element-web#23601
Fixes element-hq/element-web#22297

Here's what your changelog entry will look like:

🐛 Bug Fixes

@t3chguy
Simplify registration with email validation
9f80ce6 
Instead of having the email validation flow redirect back to the client
which is error-prone due to 2 clients racing on the /register request
we only encourage a single tab of Element (the one you started registering
on) as this fixes both the flakiness and the double-registration.
@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 11, 2023
@t3chguy t3chguy changed the title Remove redundant makeRegistrationUrl prop Simplify registration with email validation Aug 11, 2023
@t3chguy t3chguy added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems and removed T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Aug 11, 2023
@t3chguy t3chguy marked this pull request as ready for review August 14, 2023 11:37
@t3chguy t3chguy requested review from a team as code owners August 14, 2023 11:37
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
d3c2988 
… t3chguy/fix/25832

# Conflicts:
#	cypress/plugins/index.ts
#	cypress/plugins/synapsedocker/index.ts
#	cypress/support/homeserver.ts
#	yarn.lock
@t3chguy
Copy link
Member Author

t3chguy commented Aug 15, 2023

Ignoring SonarCloud coverage due to the testing being done in Cypress

andybalaam
andybalaam approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome - props for getting the email server to work. The test is great, but I don't understand the actual change in behaviour of the app.

Does this change the email that we send out? Or something in the web page?

cypress/e2e/register/email.spec.ts Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member Author

t3chguy commented Aug 15, 2023

Does this change the email that we send out? Or something in the web page?

  1. We no longer provide a next_link param so upon completion of the email validation flow the user is not redirected back to Element, instead being expected to use their initial registration tab
  2. We no longer encourage the user to end up with 2 Element Web tabs open

@t3chguy t3chguy enabled auto-merge August 15, 2023 12:10
@t3chguy t3chguy disabled auto-merge August 15, 2023 15:14
@t3chguy t3chguy merged commit 0842559 into develop Aug 15, 2023
18 of 19 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/25832 branch August 15, 2023 15:14
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 31, 2023
@Midar
Update chat/element-web to 1.11.40
f7ccbff 
Changes in [1.11.40](https://github.com/vector-im/element-web/releases/tag/v1.11.40) (2023-08-29)
=================================================================================================

## ✨ Features
 * Hide account deactivation for externally managed accounts ([\#11445](matrix-org/matrix-react-sdk#11445)). Fixes #26022. Contributed by @kerryarchibald.
 * OIDC: Redirect to delegated auth provider when signing out ([\#11432](matrix-org/matrix-react-sdk#11432)). Fixes #26000. Contributed by @kerryarchibald.
 * Disable 3pid fields in settings when `m.3pid_changes` capability is disabled ([\#11430](matrix-org/matrix-react-sdk#11430)). Fixes #25995. Contributed by @kerryarchibald.
 * OIDC: disable multi session signout for OIDC-aware servers in session manager ([\#11431](matrix-org/matrix-react-sdk#11431)). Contributed by @kerryarchibald.
 * Implement updated open dialog method of the Module API ([\#11395](matrix-org/matrix-react-sdk#11395)). Contributed by @dhenneke.
 * Polish & delabs `Exploring public spaces` feature ([\#11423](matrix-org/matrix-react-sdk#11423)).
 * Treat lists with a single empty item as plain text, not Markdown. ([\#6833](matrix-org/matrix-react-sdk#6833)). Fixes element-hq/element-meta#1265.
 * Allow managing room knocks ([\#11404](matrix-org/matrix-react-sdk#11404)). Contributed by @charlynguyen.
 * Pin the action buttons to the bottom of the scrollable dialogs ([\#11407](matrix-org/matrix-react-sdk#11407)). Contributed by @dhenneke.
 * Support Matrix 1.1 (drop legacy r0 versions) ([\#9819](matrix-org/matrix-react-sdk#9819)).

## 🐛 Bug Fixes
 * Fix path separator for Windows based systems ([\#25997](element-hq/element-web#25997)).
 * Fix instances of double translation and guard translation calls using typescript ([\#11443](matrix-org/matrix-react-sdk#11443)).
 * Fix export type "Current timeline" to match its behaviour to its name ([\#11426](matrix-org/matrix-react-sdk#11426)). Fixes #25988.
 * Fix Room Settings > Notifications file upload input being shown superfluously ([\#11415](matrix-org/matrix-react-sdk#11415)). Fixes #18392.
 * Simplify registration with email validation ([\#11398](matrix-org/matrix-react-sdk#11398)). Fixes #25832 #23601 and #22297.
 * correct home server URL ([\#11391](matrix-org/matrix-react-sdk#11391)). Fixes #25931. Contributed by @NSV1991.
 * Include non-matching DMs in Spotlight recent conversations when the DM's userId is part of the search API results ([\#11374](matrix-org/matrix-react-sdk#11374)). Contributed by @mgcm.
 * Fix useRoomMembers missing updates causing incorrect membership counts ([\#11392](matrix-org/matrix-react-sdk#11392)). Fixes #17096.
 * Show error when searching public rooms fails ([\#11378](matrix-org/matrix-react-sdk#11378)).
@0x416c69 0x416c69 mentioned this pull request Sep 15, 2023
Closed
@estellecomment estellecomment mentioned this pull request Sep 29, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
2 participants
@t3chguy @andybalaam