Update style rules under mx_AppTileMenuBar_title

[luixxiul]

For element-hq/element-web#25269

This is one of the PRs which intend to conform style rules of _AppDrawer.pcss to our naming policy. This PR intends to address the structure of the style rules under mx_AppTileMenuBar_title.

Before	After

type: task

Checklist

• Tests written for new code (and old code if feasible)
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

---

This change is marked as an internal change (Task), so will not be included in the changelog.

[luixxiul]

.mx_AppTileMenuBar_title > :last-child was this span element below. It is not clear why it was specified so (instead of .mx_AppTileMenuBar_title > span), while there has not been another element directly under mx_AppTileMenuBar_title.

[germain-gg]

I'm struggling to see the optimisation here?
Why is it a bad thing to have an inline element?

[luixxiul]

I do not have a strong opinion of inlining styles, so I am going to revert that change.

[germain-gg]

@luixxiul I think the question spans for the entire PR ?
You mention confirming to the naming policy, but I only see you created some new CSS classes and not changed old ones? Same goes with the inline style... I don't think the structure is perfect, but it seems to be holding its own weight?

[luixxiul]

You mention confirming to the naming policy, but I only see you created some new CSS classes and not changed old ones?

I am not quite sure if I understood you well, but I intentionally am trying to split tasks for the sake of reviewers who prefer small PRs. If we address several tasks on this PR, we would also rename mx_AppTileMenuBar into mx_AppTile_menuBar, creating _AppTile.pcss, moving the style rules to the file, but I would like to address them with other PRs.

[germain-gg]

I'm going by the description of the pull request here, and you mention that the changes are to conform the classes names with our styleguide.
But I do not see any changes related to that besides mx_AppTileMenuBar_title_widgetAvatar, and I do not think it was violating the style guide in the first place.

The class is scoped within mx_AppTileMenuBar, so that should not be a concern.

---

But I would also like to address the small pull request comment.
I believe it is important to a small pull request. The ideal is to make the smallest pull request possible for a coherent unit of work.

[luixxiul]

The class is scoped within mx_AppTileMenuBar, so that should not be a concern.

Yes, I would agree.

Despite the difficulty of understanding how > :last-child works, the PR seems to have become irrelevant.