Fix timestamp and read receipt group placement on ThreadView #10335

luixxiul · 2023-03-08T20:49:26Z

This PR changes style rules of the read receipts group and timestamp of hidden events so that they are displayed on the bubble layout on the thread, fixing the issue that read receipts overlapping save button of the editor on the modern layout (fixing partially, because the read receipts group will still overlap the button if it contains more than three or four avatars).

It looks the read receipts group has been enabled on the thread without taking the design compatibility into consideration pretty much, in order to make the thread implementation out of beta, so simply displaying it introduces a couple of issues, such as it being hidden by your own avatar on the bubble layout.

Also, for the modern layout, if you reserve horizontal space for the read receipt group to fix the issues element-hq/element-web#23576 and element-hq/element-web#23569 (comment), then it will create a similar issue as element-hq/element-web#21890 wasting a lot of horizontal space like this.

My question is: do we want to fix the obvious bugs at first, improving implementation step by step with other PRs, or do we want to improve the design of read receipts group on the thread and implement it as well with this PR to avoid the issues mentioned above from being introduced? I would prefer the former.

	Before	After
Thread panel

Timestamp
Read receipts
Read receipts
Read receipts (modern layout)
MessageActionBar
Editor (modern layout)

Fixes element-hq/element-web#24773
Fixes element-hq/element-web#23867
Fixes element-hq/element-web#24744
Fixes element-hq/element-web#24808 with this commit
For element-hq/element-web#21774
Follow-up to #10284
For element-hq/element-web#23569
For element-hq/element-web#23326
For element-hq/element-web#23576

type: defect

Checklist

Tests written for new code (and old code if feasible)
Linter and other CI checks pass
Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

Fix timestamp and read receipt group placement on ThreadView (#10335). Fixes Read receipts for messages by others on bubble layout in a thread do not stick to the right side of the thread panel element-hq/element-web#24773, Thread read receipts are pushed off screen in bubble leayout element-hq/element-web#23867 Timestamp of hidden events on a thread in bubble layout is out of the thread panel element-hq/element-web#24744 and Redacted message in thread has read receipt *above* message instead of at the bottom element-hq/element-web#24808. Contributed by @luixxiul.

Signed-off-by: Suguru Hirahara <[email protected]>

…ble layout Signed-off-by: Suguru Hirahara <[email protected]>

Signed-off-by: Suguru Hirahara <[email protected]>

…bble layout Signed-off-by: Suguru Hirahara <[email protected]>

…nt on bubble layout Signed-off-by: Suguru Hirahara <[email protected]>

Signed-off-by: Suguru Hirahara <[email protected]>

luixxiul · 2023-03-08T21:11:55Z

src/components/views/rooms/EventTile.tsx

                        </div>,
+                        msgOption,


See: https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-9ff5535291b7c2e655ccd3d02c4f632b6f2dc9c30072514641e31c2a8751c57eR1287 and https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-9ff5535291b7c2e655ccd3d02c4f632b6f2dc9c30072514641e31c2a8751c57eR1398. Both of them are placed outside of mx_EventTile_line.

I didn't understand what these links were supposed to tell me. For the benefit of future reviewers:

This brings TimelineRenderingType.Thread in line with the other timeline rendering types by moving the msgOption (ie, the read receipt group) outside the mx_EventTile_line.

luixxiul · 2023-03-08T21:13:34Z

cypress/e2e/threads/threads.spec.ts

-                // Make sure the margin is NOT applied to mx_EventTile_line
+        cy.get(".mx_ThreadView .mx_GenericEventListSummary[data-layout=bubble]").within(() => {
+            cy.get(".mx_EventTile_info.mx_EventTile_last")
+                // 49px: --EventTile_bubble-margin-inline-start


https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1108

luixxiul · 2023-03-08T21:14:46Z

res/css/views/rooms/_EventTile.pcss

@@ -1082,28 +1077,58 @@ $left-gutter: 64px;
                    top: 2px; /* Align with avatar */
                }

+                .mx_ReadReceiptGroup {
+                    inset-block-start: calc(-$font-22px); /* Align with hidden event content */


https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR356

3px is not required here

luixxiul · 2023-03-08T21:17:34Z

res/css/views/rooms/_EventTile.pcss

+                    &.mx_EventTile_verified.mx_EventTile_info .mx_EventTile_line,
+                    &.mx_EventTile_unverified.mx_EventTile_info .mx_EventTile_line,
+                    &.mx_EventTile_unknown.mx_EventTile_info .mx_EventTile_line {
+                        padding-inline-start: var(--ThreadView_group_spacing-start);


https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1200

luixxiul · 2023-03-08T21:18:03Z

res/css/views/rooms/_EventTile.pcss


            &::before {
-                inset-inline: calc(-1 * var(--BaseCard_EventTile-spacing-inline));
+                inset-inline-start: calc(-1 * var(--BaseCard_EventTile-spacing-inline));
+                inset-inline-end: calc(-1 * var(--EventTile_bubble-margin-inline-end));


https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1207 For hover effect

please don't just link to another line in the diff. What am I supposed to learn by looking at that link?

luixxiul · 2023-03-08T21:20:47Z

res/css/views/rooms/_EventTile.pcss

+
+                &[data-self="true"] {
+                    /* Align the avatar and mx_EventTile_line at the center on hidden event tile line */
+                    align-items: center;


https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1235 Against align-items: end

luixxiul · 2023-03-08T21:21:44Z

res/css/views/rooms/_EventTile.pcss

-                    .mx_EventTile_content,
-                    .mx_RedactedBody {
-                        margin-inline-start: calc(var(--ThreadView_group_spacing-start) + 14px + 6px);
+                    /* Not available on the actual UI anyway as the hidden event expand button is hidden above */


https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1048 The button is hidden, maybe for now? Let's fix the issue in case it will be displayed.

luixxiul · 2023-03-08T21:23:21Z

cypress/e2e/threads/threads.spec.ts

+                // 49px: --EventTile_bubble-margin-inline-start
+                .should("have.css", "margin-inline-start", "49px");
+            cy.get(".mx_EventTile_info.mx_EventTile_last .mx_EventTile_line .mx_EventTile_content")
+                // Make sure the margin is NOT applied to mx_EventTile_content


https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1091

Signed-off-by: Suguru Hirahara <[email protected]>

luixxiul · 2023-03-09T21:12:13Z

Found some other things to be fixed... working on them.

The declaration has been introduced with 73d346e introducing bubble layout in ThreadView. It has been required because '.mx_ThreadView .mx_EventTile' was styled with flexbox. The flexbox model was deprecated, and the declaration is no longer necessary. Signed-off-by: Suguru Hirahara <[email protected]>

The declarations are specified by _EventBubbleTile.pcss, therefore they are not required here. display:block is not needed here. Signed-off-by: Suguru Hirahara <[email protected]>

Signed-off-by: Suguru Hirahara <[email protected]>

…ubble layout Signed-off-by: Suguru Hirahara <[email protected]>

…f the layouts Signed-off-by: Suguru Hirahara <[email protected]>

Signed-off-by: Suguru Hirahara <[email protected]>

…le-layout

luixxiul · 2023-03-10T09:00:45Z

res/css/views/rooms/_EventTile.pcss

@@ -1234,8 +1234,6 @@ $left-gutter: 64px;
            }

            &[data-self="true"] {
-                align-items: flex-end;


See: 73d346e#diff-bd83194d78de871bc4ad1c4e8d43102c4368481bbb90705152d3d17fea813919R881

again, what do I learn by looking at that link?

luixxiul · 2023-03-10T09:06:48Z

res/css/views/right_panel/_TimelineCard.pcss

-                inset-inline-end: calc(
-                    -1 * var(--ReadReceiptGroup_EventBubbleTile-spacing-end) + $container-gap-width + 6px
-                );
+                inset-inline-end: var(--BaseCard_EventTile_bubble_RR-inset-inline-end);


See: https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1230

See: https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1230

Once more, just linking to a diff isn't very helpful.

In this case, this is a link to the other place that --BaseCard_EventTile_bubble_RR-inset-inline-end is now used.

luixxiul · 2023-03-10T09:18:03Z

@andybalaam Would you please review when you have some time? Thanks in advance.

andybalaam · 2023-03-10T11:05:03Z

My question is: do we want to fix the obvious bugs at first, improving implementation step by step with other PRs, or do we want to improve the design of read receipts group on the thread and implement it as well with this PR to avoid the issues mentioned above from being introduced? I would prefer the former.

Yes, 100% - I would prefer to review small changes that fix an obvious bug. Thank you for your work on this!

andybalaam · 2023-03-10T14:57:05Z

I'm looking, but it's going to take me a while to get my head around all this, next week.

luixxiul · 2023-03-10T15:22:14Z

No problem. It is a little bit large one and you seem to be busy with other tasks, so take your time 👍

richvdh

I've started having a look at this, but there are quite a few things I don't understand. I have asked some questions below, though there are parts I haven't even looked at yet.

The changes have the air of being sensible, but they are hard to follow, and generally I wonder if this trying to fix too many things at once. Would it be possible to break this PR down into smaller increments to help us review it?

res/css/views/right_panel/_TimelineCard.pcss

richvdh · 2023-03-22T11:46:50Z

res/css/views/right_panel/_BaseCard.pcss

    --BaseCard_EventTile_line-padding-block: 2px;
    --BaseCard_EventTile-spacing-inline: 36px; /* TODO: Use a spacing variable */
-    --BaseCard_header-button-size: 24px;
+
+    /* Moving the read receipts group inside BaseCard */


Comments should be in the imperative ("Move"), not the present participle ("Moving").

But in this case, the useful information is what this variable does, rather than how it is calculated.

Suggested change

/* Moving the read receipts group inside BaseCard */

/* The `inset-inline-end` (ie, `right` offset) for RR groups in bubble mode. */

richvdh · 2023-03-22T11:59:47Z

res/css/views/rooms/_ReadReceiptGroup.pcss

@@ -14,9 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */

-.mx_ReadReceiptGroup {
+/* Required due to alphabetic order of CSS import */


we do this elsewhere without a comment; I don't think the comment here is that helpful.

Suggested change

/* Required due to alphabetic order of CSS import */

richvdh · 2023-03-22T12:06:09Z

res/css/views/rooms/_ReadReceiptGroup.pcss

@@ -14,9 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */

-.mx_ReadReceiptGroup {
+/* Required due to alphabetic order of CSS import */
+:root {
    --ReadReceiptGroup_EventBubbleTile-spacing-end: 78px;


it would be good to add a comment saying what this variable does though. I'm struggling to figure it out. The best definition I came up with was:

Suggested change

--ReadReceiptGroup_EventBubbleTile-spacing-end: 78px;

/* The negative of the `inset-inline-end` of ReadReceiptGroups in bubble mode. */

--ReadReceiptGroup_EventBubbleTile-spacing-end: 78px;

Any better ideas?

(why isn't it just -78px, to save us doing calc(-1 * var(--ReadReceiptGroup_EventBubbleTile-spacing-end)) everywhere it is used?)

richvdh · 2023-03-22T12:07:44Z

res/css/views/rooms/_EventTile.pcss

-        display: flex;
-        flex-direction: column;


why is it safe to remove these?

richvdh · 2023-03-22T12:12:16Z

res/css/views/rooms/_EventTile.pcss

-            .mx_ViewSourceEvent_toggle {
-                display: none; /* hide the hidden event expand button, not enough
-                space, view source can still be used */
-            }
-


is moving this necessary?

richvdh · 2023-03-22T12:16:59Z

src/components/views/rooms/EventTile.tsx

                        </div>,
+                        msgOption,


I didn't understand what these links were supposed to tell me. For the benefit of future reviewers:

This brings TimelineRenderingType.Thread in line with the other timeline rendering types by moving the msgOption (ie, the read receipt group) outside the mx_EventTile_line.

richvdh · 2023-03-22T12:17:59Z

res/css/views/rooms/_EventTile.pcss


            &::before {
-                inset-inline: calc(-1 * var(--BaseCard_EventTile-spacing-inline));
+                inset-inline-start: calc(-1 * var(--BaseCard_EventTile-spacing-inline));
+                inset-inline-end: calc(-1 * var(--EventTile_bubble-margin-inline-end));


please don't just link to another line in the diff. What am I supposed to learn by looking at that link?

richvdh · 2023-03-22T12:18:12Z

res/css/views/rooms/_EventTile.pcss

@@ -1234,8 +1234,6 @@ $left-gutter: 64px;
            }

            &[data-self="true"] {
-                align-items: flex-end;


again, what do I learn by looking at that link?

richvdh · 2023-03-22T12:19:48Z

res/css/views/right_panel/_TimelineCard.pcss

-                inset-inline-end: calc(
-                    -1 * var(--ReadReceiptGroup_EventBubbleTile-spacing-end) + $container-gap-width + 6px
-                );
+                inset-inline-end: var(--BaseCard_EventTile_bubble_RR-inset-inline-end);


See: https://github.com/matrix-org/matrix-react-sdk/pull/10335/files#diff-5d3e25eb1d22dd7a96e0e87ea9c1298dc7dbce8eb965d30b2d1ebc1436bfec3fR1230

Once more, just linking to a diff isn't very helpful.

In this case, this is a link to the other place that --BaseCard_EventTile_bubble_RR-inset-inline-end is now used.

luixxiul · 2023-03-22T12:41:56Z

Thanks for the educational insights.

converting for now to make commits understandable for those who are not familiar with the style rules around EventTiles

luixxiul · 2023-03-22T12:44:51Z

@richvdh Also I've felt your reviews aggressive and impolite, which is almost enough to have me give up working on this.

English lesson Co-authored-by: Richard van der Hoff <[email protected]>

richvdh · 2023-03-22T13:30:27Z

@richvdh Also I've felt your reviews aggressive and impolite, which is almost enough to have me give up working on this.

I'm sorry you feel that way. It's certainly not intended that way. To be clear: I (along with the rest of the team) am very grateful for all the great work you are doing on improving the application.

I know my review style can be a bit "blunt" and to the point. Ultimately I'm just trying to make sure we do our best to keep the codebase maintainable. But sometimes I am in a bit of a hurry and I forget that there is a human reading my comments. I will do my best to moderate my language.

Having said that: I do encourage you to look at your pull requests and think how you can make them easy for reviewers to understand. If you were doing a review yourself, without the benefit of having just worked on this bit of code, what would you find helpful? Sometimes that will mean making smaller PRs; sometimes it will mean adding comments to the diff which explain why you made a particular choice. I think that one reason this PR hasn't made progress more quickly is because it's a bit difficult to understand.

Anyway, to reiterate: thank you very much for all your work on the project. Please do keep it up!

andybalaam · 2023-05-03T12:40:45Z

@luixxiul thank you again for this. I've finally got around to reviewing it again today, and I can't get my head around it.

Please can you break it down into small pieces that we can review one at a time? Thanks!

andybalaam · 2023-05-09T12:59:29Z

I'm going to close this because we're not looking to merge it, but we really appreciate the work and would like to merge it when you can break it down into smaller parts.

luixxiul added 13 commits March 9, 2023 05:08

Fix timestamp on bubble layout on threadview

f98fcd7

Signed-off-by: Suguru Hirahara <[email protected]>

Fix info event line styles on bubble layout

556daae

Signed-off-by: Suguru Hirahara <[email protected]>

Fix read receipt group on ThreadView on modern/group layout

66ecfac

Signed-off-by: Suguru Hirahara <[email protected]>

Align read receipt groups of hidden event lines and normal bubble tiles

c2f0cf6

Signed-off-by: Suguru Hirahara <[email protected]>

Enable the test to check whether read receipt group is visible on bub…

6e1688b

…ble layout Signed-off-by: Suguru Hirahara <[email protected]>

Edit padding of hidden event lines

41638c5

Signed-off-by: Suguru Hirahara <[email protected]>

Edit the test to check mx_EventTile_line margin of hidden event on bu…

fd669a3

…bble layout Signed-off-by: Suguru Hirahara <[email protected]>

Edit the test to check mx_EventTile inline start margin of hidden eve…

a26a154

…nt on bubble layout Signed-off-by: Suguru Hirahara <[email protected]>

Edit read receipt group on bubble layout

6b5f515

Signed-off-by: Suguru Hirahara <[email protected]>

Snapshot of the edited EventTile

691e00b

Signed-off-by: Suguru Hirahara <[email protected]>

Edit comments and declarations

deb38da

Signed-off-by: Suguru Hirahara <[email protected]>

Add a comment

6cb5e59

Signed-off-by: Suguru Hirahara <[email protected]>

Remove inset declaration for MessageActionBar on hidden events

30162b4

Signed-off-by: Suguru Hirahara <[email protected]>

github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Mar 8, 2023

github-actions bot deployed to Netlify March 8, 2023 20:54 View deployment

lint

a663e7f

Signed-off-by: Suguru Hirahara <[email protected]>

github-actions bot deployed to Netlify March 8, 2023 21:05 View deployment

luixxiul commented Mar 8, 2023

View reviewed changes

luixxiul added 3 commits March 9, 2023 18:42

Apply the override to selected hidden event line only

41ee51d

Signed-off-by: Suguru Hirahara <[email protected]>

Add comments

9c19038

Signed-off-by: Suguru Hirahara <[email protected]>

Sort declarations semantically

5b7784b

Signed-off-by: Suguru Hirahara <[email protected]>

github-actions bot deployed to Netlify March 9, 2023 09:48 View deployment

github-actions bot deployed to Netlify March 9, 2023 19:45 View deployment

luixxiul added 8 commits March 10, 2023 16:14

Remove redundant declarations

d1f9eba

The declarations are specified by _EventBubbleTile.pcss, therefore they are not required here. display:block is not needed here. Signed-off-by: Suguru Hirahara <[email protected]>

Edit a comment

2acac19

Signed-off-by: Suguru Hirahara <[email protected]>

Apply spacing style of hidden event line on modern layout to one on b…

e87f979

…ubble layout Signed-off-by: Suguru Hirahara <[email protected]>

Merge styles and apply the same style rules of block padding to all o…

7741c61

…f the layouts Signed-off-by: Suguru Hirahara <[email protected]>

Removing a nesting

bce1619

Signed-off-by: Suguru Hirahara <[email protected]>

Remove width declaration here to let inherited value enabled

9cd24ff

Signed-off-by: Suguru Hirahara <[email protected]>

Merge branch 'develop' into fix-timestamp-readreceipt-threadview-bubb…

ac48775

…le-layout

github-actions bot deployed to Netlify March 10, 2023 08:58 View deployment

luixxiul commented Mar 10, 2023

View reviewed changes

luixxiul mentioned this pull request Mar 10, 2023

Regressions on the right chat panel with bubble message layout enabled element-hq/element-web#21774

Closed

3 tasks

luixxiul mentioned this pull request Mar 13, 2023

Redacted message in thread has read receipt *above* message instead of at the bottom element-hq/element-web#24808

Open

richvdh suggested changes Mar 22, 2023

View reviewed changes

luixxiul marked this pull request as draft March 22, 2023 12:42

Update res/css/views/right_panel/_TimelineCard.pcss

1e9bb9a

English lesson Co-authored-by: Richard van der Hoff <[email protected]>

github-actions bot deployed to Netlify March 22, 2023 13:32 View deployment

andybalaam closed this May 9, 2023

luixxiul deleted the fix-timestamp-readreceipt-threadview-bubble-layout branch June 1, 2023 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix timestamp and read receipt group placement on ThreadView #10335

Fix timestamp and read receipt group placement on ThreadView #10335

luixxiul commented Mar 8, 2023 •

edited by github-actions bot

Loading

luixxiul Mar 8, 2023

richvdh Mar 22, 2023

luixxiul Mar 8, 2023

luixxiul Mar 8, 2023

luixxiul Mar 8, 2023

luixxiul Mar 8, 2023 •

edited

Loading

richvdh Mar 22, 2023

luixxiul Mar 8, 2023 •

edited

Loading

luixxiul Mar 8, 2023 •

edited

Loading

luixxiul Mar 8, 2023

luixxiul commented Mar 9, 2023

luixxiul Mar 10, 2023

richvdh Mar 22, 2023

luixxiul Mar 10, 2023

richvdh Mar 22, 2023

luixxiul commented Mar 10, 2023

andybalaam commented Mar 10, 2023

andybalaam commented Mar 10, 2023

luixxiul commented Mar 10, 2023 •

edited

Loading

richvdh left a comment

richvdh Mar 22, 2023

richvdh Mar 22, 2023

richvdh Mar 22, 2023

richvdh Mar 22, 2023

richvdh Mar 22, 2023

richvdh Mar 22, 2023

richvdh Mar 22, 2023

richvdh Mar 22, 2023

richvdh Mar 22, 2023

luixxiul commented Mar 22, 2023

luixxiul commented Mar 22, 2023 •

edited

Loading

richvdh commented Mar 22, 2023

andybalaam commented May 3, 2023

andybalaam commented May 9, 2023

	/* Moving the read receipts group inside BaseCard */
	/* The `inset-inline-end` (ie, `right` offset) for RR groups in bubble mode. */

	--ReadReceiptGroup_EventBubbleTile-spacing-end: 78px;
	/* The negative of the `inset-inline-end` of ReadReceiptGroups in bubble mode. */
	--ReadReceiptGroup_EventBubbleTile-spacing-end: 78px;

Fix timestamp and read receipt group placement on ThreadView #10335

Fix timestamp and read receipt group placement on ThreadView #10335

Conversation

luixxiul commented Mar 8, 2023 • edited by github-actions bot Loading

Checklist

🐛 Bug Fixes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luixxiul Mar 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luixxiul Mar 8, 2023 • edited Loading

Choose a reason for hiding this comment

luixxiul Mar 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luixxiul commented Mar 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luixxiul commented Mar 10, 2023

andybalaam commented Mar 10, 2023

andybalaam commented Mar 10, 2023

luixxiul commented Mar 10, 2023 • edited Loading

richvdh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luixxiul commented Mar 22, 2023

luixxiul commented Mar 22, 2023 • edited Loading

richvdh commented Mar 22, 2023

andybalaam commented May 3, 2023

andybalaam commented May 9, 2023

luixxiul commented Mar 8, 2023 •

edited by github-actions bot

Loading

luixxiul Mar 8, 2023 •

edited

Loading

luixxiul Mar 8, 2023 •

edited

Loading

luixxiul Mar 8, 2023 •

edited

Loading

luixxiul commented Mar 10, 2023 •

edited

Loading

luixxiul commented Mar 22, 2023 •

edited

Loading