Code review changes

Signed-off-by: Mikhail Aheichyk <[email protected]>
matrix-org · Sep 19, 2023 · a377e7c · a377e7c
1 parent 54c6935
commit a377e7c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/utils/membership.ts b/src/utils/membership.ts
@@ -69,7 +69,6 @@ export function getEffectiveMembership(membership: string): EffectiveMembership
  if (membership === "invite") {
  return EffectiveMembership.Invite;
  } else if (membership === "join" || (SettingsStore.getValue("feature_ask_to_join") && membership === "knock")) {
- // TODO: Include knocks? Update docs as needed in the enum. https://github.com/vector-im/element-web/issues/14237
  return EffectiveMembership.Join;
  } else {
  // Probably a leave, kick, or ban

diff --git a/test/utils/membership-test.ts b/test/utils/membership-test.ts
@@ -21,8 +21,7 @@ import { isKnockDenied, waitForMember } from "../../src/utils/membership";
 import { createTestClient, mkRoomMember, stubClient } from "../test-utils";
 
 describe("isKnockDenied", () => {
- // const userId = MatrixClientPeg.get()!.getSafeUserId() //TODO: MA
- const userId = "some";
+ const userId = "alice";
  let client: jest.Mocked<MatrixClient>;
  let room: Room;