Tweak UIA postMessage check to work cross-origin (#12878)

* Soften UIA fallback postMessage check to work cross-origin Signed-off-by: Michael Telatynski <[email protected]> * Do the same for the SSO UIA flow Signed-off-by: Michael Telatynski <[email protected]> * Check against MessageEvent::source instead Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
matrix-org · Aug 16, 2024 · 88cf643 · 88cf643
1 parent 7a91e3e
commit 88cf643
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/components/views/auth/InteractiveAuthEntryComponents.tsx b/src/components/views/auth/InteractiveAuthEntryComponents.tsx
@@ -833,7 +833,7 @@ export class SSOAuthEntry extends React.Component<ISSOAuthEntryProps, ISSOAuthEn
  };
 
  private onReceiveMessage = (event: MessageEvent): void => {
- if (event.data === "authDone" && event.origin === this.props.matrixClient.getHomeserverUrl()) {
+ if (event.data === "authDone" && event.source === this.popupWindow) {
  if (this.popupWindow) {
  this.popupWindow.close();
  this.popupWindow = null;
@@ -950,7 +950,7 @@ export class FallbackAuthEntry extends React.Component<IAuthEntryProps> {
  };
 
  private onReceiveMessage = (event: MessageEvent): void => {
- if (event.data === "authDone" && event.origin === this.props.matrixClient.getHomeserverUrl()) {
+ if (event.data === "authDone" && event.source === this.popupWindow) {
  this.props.submitAuthDict({});
  }
  };