Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Fix forced lowercase username in login/registration flows (#9329)
Browse files Browse the repository at this point in the history
* remove lowercase (proposal)

Lowercase doesn't make sense here (at least in German). I suggest removing it or creating a new translatable string.

* remove lowercase

Lowercase doesn't make sense here (at least in German). I suggest removing it or creating a new translatable string.

* Update screenshot

---------

Co-authored-by: David Baker <[email protected]>
  • Loading branch information
vrifox and dbkr authored Feb 15, 2024
1 parent 0856c76 commit 2c0ee1e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/components/views/auth/PasswordLogin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ export default class PasswordLogin extends React.PureComponent<IProps, IState> {
key="username_input"
type="text"
label={_t("common|username")}
placeholder={_t("common|username").toLocaleLowerCase()}
placeholder={_t("common|username")}
value={this.props.username}
onChange={this.onUsernameChanged}
onBlur={this.onUsernameBlur}
Expand Down
2 changes: 1 addition & 1 deletion src/components/views/auth/RegistrationForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ export default class RegistrationForm extends React.PureComponent<IProps, IState
type="text"
autoFocus={true}
label={_t("common|username")}
placeholder={_t("common|username").toLocaleLowerCase()}
placeholder={_t("common|username")}
value={this.state.username}
onChange={this.onUsernameChange}
onValidate={this.onUsernameValidate}
Expand Down

0 comments on commit 2c0ee1e

Please sign in to comment.