Clean AES file #4440
Merged
Clean AES file #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/clean-aes
branch
from
06ffbe9
to
86a69e2
Compare
dbkr
approved these changes
Oct 2, 2024
andybalaam
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 25a34c1.
Checklist
public/exportedsymbols have accurate TSDoc documentation.The react-sdk tests were mocking in a very intrusively way the AES functions. After #4431 & element-hq/matrix-react-sdk#97, the tests are no longer using theses functions so we can clean the exports and move back
calculateKeyCheck.