Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax & type check for Node.js example on CI #4410

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 17, 2024

This uses node --check and tsc to perform some basic syntax and type checking on the Node.js example.

It's slightly odd to have this running on every PR when the JS SDK version is pinned in the example's package.json. If we find a way to update the JS SDK in the example via renovate, maybe we could switch the CI to use the local SDK instead?

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant