Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: add idTokenClaims to authorization grant response #3765

Merged
merged 4 commits into from
Oct 4, 2023
Merged

OIDC: add idTokenClaims to authorization grant response #3765

merged 4 commits into from
Oct 4, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Oct 2, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#25839
With matrix-org/matrix-react-sdk#11691

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Tasks for the team like planning label Oct 2, 2023
@kerryarchibald kerryarchibald mentioned this pull request Oct 2, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald marked this pull request as ready for review October 2, 2023 04:28
@kerryarchibald kerryarchibald requested a review from a team as a code owner October 2, 2023 04:28
@germain-gg germain-gg removed their request for review October 2, 2023 09:15
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 3, 2023
@kerryarchibald kerryarchibald mentioned this pull request Oct 3, 2023
Merged
3 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@kerryarchibald kerryarchibald added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2023
@t3chguy t3chguy merged commit 6e8d15e into develop Oct 4, 2023
@t3chguy t3chguy deleted the kerry/25392/persist-oidc-token-claims branch October 4, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kerryarchibald @dbkr @t3chguy