Pass to-device messages into rust crypto-sdk #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a separate API, because `ClientEvent.ToDeviceEvent` is only emitted for successfully decrypted to-device events
richvdh
force-pushed
the
rav/element-r/incoming_to_device
branch
from
d5d5b6f to
bd57795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new method in
SyncCryptoCallbacks. We can't just piggyback ontoClientEvent.ToDeviceEvent, because that is only emitted for successfully decrypted to-device events.We also don't really want to hook into the EventMapper mechanism (as the current
Cryptoimplementation does), because the rust crypto api expects the raw to-device events, rather than those that have been mangled into MatrixEvents.Part of element-hq/element-web#21972.
This change is marked as an internal change (Task), so will not be included in the changelog.