Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle outgoing requests from rust crypto SDK #3019

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 4, 2023

The rust matrix-sdk-crypto has an outgoingRequests() method which we need to poll, and make the requested requests.

Part of element-hq/element-web#21972.


This change is marked as an internal change (Task), so will not be included in the changelog.

... so that we can make outbound requests.
@richvdh richvdh requested a review from a team as a code owner January 4, 2023 11:06
@richvdh richvdh marked this pull request as draft January 4, 2023 11:06
@richvdh richvdh added the T-Task Tasks for the team like planning label Jan 4, 2023
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@richvdh richvdh merged commit 9ac7165 into develop Jan 4, 2023
@richvdh richvdh deleted the rav/element-r/outgoing_requests branch January 4, 2023 12:17
richvdh added a commit that referenced this pull request Jan 4, 2023
Apparently `??=` was only added to javascript in ES12, and our eleweb build
doesn't support it.

Fixes breakage introduced in #3019.
richvdh added a commit that referenced this pull request Jan 31, 2023
This is a follow-up to #3019: it implements the remaining two types of message types, now that rust SDK has sensibly-shaped types for them.
Copy link

@MORFELB99 MORFELB99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bueno l verdad

MORFE - YOU TUBE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants