Add support for Swift Package Manager. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy base types into types for a single path.
stefanceriu
approved these changes
Aug 18, 2022
Comment on lines
+21
to
+27
| - name: Install Swift | ||
| uses: slashmo/[email protected] | ||
| with: | ||
| version: 5.6 | ||
|
|
||
| - name: Build for Swift | ||
| run: swift build |
| @@ -0,0 +1,36 @@ | |||
| // | |||
There was a problem hiding this comment.
Should we delete the original one from base_types or would that break Element? Might be worth importing the swift package into Element too.
There was a problem hiding this comment.
Well the main issue here is that the stub generator deletes types/swift before generating the latest types. So for now it will need to be a copy each time. And yep, we definitely should migrate to the package for EI as we'll be able to specify a version instead of a commit on the release/swift branch.
|
Nice! |
germain-gg
approved these changes
Aug 23, 2022
| @@ -0,0 +1,36 @@ | |||
| // | |||
| // Copyright 2021 New Vector Ltd | |||
There was a problem hiding this comment.
Copyright year is incorrect, but that links to #68
There was a problem hiding this comment.
I've added a note in that issue about handling base_types 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
base_types/swiftintotypes/swiftafter stub generation to have a single path for all Swift files.main(#40).