Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New events and subtypes for user onboarding tasklist #67

Merged
merged 3 commits into from
Jul 25, 2022
Merged

New events and subtypes for user onboarding tasklist #67

merged 3 commits into from
Jul 25, 2022

Conversation

justjanne
Copy link
Contributor

@justjanne justjanne force-pushed the justjanne/feat/user-onboarding-tasklist branch from 2d72e54 to f21e9bc Compare July 25, 2022 10:09
@justjanne justjanne force-pushed the justjanne/feat/user-onboarding-tasklist branch from f21e9bc to b8b18fd Compare July 25, 2022 10:33
@germain-gg germain-gg self-requested a review July 25, 2022 10:36
germain-gg
germain-gg approved these changes Jul 25, 2022
View reviewed changes
Copy link

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me 👍

types/kotlin2/NotificationPermissionChanged.kt Outdated Show resolved Hide resolved
types/swift/NotificationPermissionChanged.swift Outdated Show resolved Hide resolved
@justjanne justjanne marked this pull request as ready for review July 25, 2022 11:01
@justjanne justjanne requested a review from a team as a code owner July 25, 2022 11:01
@justjanne justjanne requested a review from pixlwave July 25, 2022 11:01
pixlwave
pixlwave reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, I've added one thought inline :)

schemas/NotificationPermissionChanged.json Outdated Show resolved Hide resolved
@justjanne justjanne requested a review from pixlwave July 25, 2022 12:00
pixlwave
pixlwave approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

schemas/PermissionChanged.json Outdated Show resolved Hide resolved
@justjanne justjanne merged commit 851b46a into main Jul 25, 2022
@justjanne justjanne deleted the justjanne/feat/user-onboarding-tasklist branch July 25, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justjanne @germain-gg @pixlwave