Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PseudoID Invites #398

Merged
merged 10 commits into from
Jul 6, 2023
Merged

PseudoID Invites #398

merged 10 commits into from
Jul 6, 2023

Conversation

devonh
Copy link
Contributor

@devonh devonh commented Jun 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 60.96% and project coverage change: +0.58 🎉

Comparison is base (90ad5fa) 56.95% compared to head (32e8c29) 57.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   56.95%   57.54%   +0.58%     
==========================================
  Files          50       51       +1     
  Lines        6632     6962     +330     
==========================================
+ Hits         3777     4006     +229     
- Misses       2498     2561      +63     
- Partials      357      395      +38     
Impacted Files Coverage Δ
eventcontent.go 76.43% <ø> (ø)
fclient/federationclient.go 11.55% <0.00%> (-0.32%) ⬇️
eventauth.go 56.97% <25.00%> (+1.99%) ⬆️
keyring.go 40.37% <37.93%> (-0.21%) ⬇️
spec/senderid.go 62.50% <50.00%> (-37.50%) ⬇️
performjoin.go 59.79% <52.05%> (-1.49%) ⬇️
invite.go 79.27% <53.33%> (-5.34%) ⬇️
handlejoin.go 73.06% <57.14%> (-2.64%) ⬇️
fclient/invitev3.go 66.66% <66.66%> (ø)
performinvite.go 68.33% <68.58%> (-25.67%) ⬇️
... and 2 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

performinvite.go Show resolved Hide resolved
eventcrypto.go Outdated Show resolved Hide resolved
@S7evinK
Copy link
Contributor

S7evinK commented Jul 3, 2023

Also, from manually testing: Rejecting invites doesn't seem to do the right thing, possibly only in the SyncAPI, as instead of @bob:server2.localhost rejected the invitation I'm seeing @bob:server2.localhost left the room instead.

@devonh devonh merged commit ad3d32b into main Jul 6, 2023
5 of 7 checks passed
@devonh devonh deleted the invite branch July 6, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants