Fix #150: latch closed to avoid logging after close() #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously trusted the rust layer to not invoke callbacks after calling `Close()`. In practice, this gets violated when there is a sliding sync response at the same time as `Close()` is called. Fix this by remembering when we called `Close()` and refusing to log to stdout afterwards. Note we still log to file.
andybalaam
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously trusted the rust layer to not invoke callbacks after calling
Close(). In practice, this gets violated when there is a sliding sync response at the same time asClose()is called. Fix this by remembering when we calledClose()and refusing to log to stdout afterwards. Note we still log to file.