Add SSS support #129
Merged
Add SSS support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the timeout between HS2 coming online again and Charlie on HS1 sending the message is too short, HS1 will reject Charlie's attempt to `/keys/claim` with a HTTP 502 and "Not ready for retry". It does this because nothing cleared the 10 minute backoff which was created when HS2 went offline. In SS, the backoff gets cleared by Bob on HS2 hitting `/keys/query` on HS1. It does this due to receiving data about Charlie (his join) promptly down `/sync`. This does not seem to happen in SSS, instead the data does appear but only after the 30s timeout is reached. Therefore, we need to wait at least 30s + some grace time for HS1 to realise HS2 is back online.
|
So smooooth… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses SSS instead of SS for rust clients.