Update js-sdk import #126
Merged
Update js-sdk import #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, we won't be able to run complement-crypto against an unbuilt js-sdk (ie, a js-sdk which has been checked out from git but not yet `yarn build`-ed). Arguably, we should import from the proper entry points, since that gives a more representative test of how matrix-js-sdk is *meant* to be used. But that involves adding a `yarn build` to the CI somewhere and I don't have the energy for that right now.
andybalaam
approved these changes
Aug 21, 2024
kegsay
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, we won't be able to run complement-crypto against an unbuilt js-sdk (ie, a js-sdk which has been checked out from git but not yet
yarn build-ed).Arguably, we should import from the proper entry points, since that gives a more representative test of how matrix-js-sdk is meant to be used. But that involves adding a
yarn buildto the CI somewhere and I don't have the energy for that right now.