add redis cluster capability

[haristku]

Description:

breaking down the previous PR to specific part

• add redis cluster capability

---

@AltamashShaikh

i already solved the issue on the already checked "Enable Redis Sentinel" using this line, but i need your suggestion on whether do i need to add a version migration "Updates" to run the sql script below or not?

INSERT INTO matomo_plugin_setting (plugin_name, setting_name, setting_value) 
SELECT * FROM (
    SELECT plugin_name, 'useWhatRedisBackendType' AS setting_name, CASE WHEN setting_value=1 THEN 2 ELSE 1 END AS setting_value FROM matomo_plugin_setting 
    WHERE plugin_name='QueuedTracking' AND setting_name='useSentinelBackend'
) AS tmp 
WHERE NOT EXISTS (
    SELECT * FROM matomo_plugin_setting
    WHERE 
        (plugin_name='QueuedTracking' AND setting_name='useWhatRedisBackendType') 
        OR (plugin_name='QueuedTracking' AND setting_name='backend' AND setting_value!='redis')
);

ty.

[snake14]

Looks pretty good. I only had one suggested change. Sadly, I don't have a clustered environment to test with.

[snake14]

Description:

breaking down the previous PR to specific part

• add redis cluster capability

@AltamashShaikh

i already solved the issue on the already checked "Enable Redis Sentinel" using this line, but i need your suggestion on whether do i need to add a version migration "Updates" to run the sql script below or not?

INSERT INTO matomo_plugin_setting (plugin_name, setting_name, setting_value) 
SELECT * FROM (
    SELECT plugin_name, 'useWhatRedisBackendType' AS setting_name, CASE WHEN setting_value=1 THEN 2 ELSE 1 END AS setting_value FROM matomo_plugin_setting 
    WHERE plugin_name='QueuedTracking' AND setting_name='useSentinelBackend'
) AS tmp 
WHERE NOT EXISTS (
    SELECT * FROM matomo_plugin_setting
    WHERE 
        (plugin_name='QueuedTracking' AND setting_name='useWhatRedisBackendType') 
        OR (plugin_name='QueuedTracking' AND setting_name='backend' AND setting_value!='redis')
);

ty.

@haristku That seems a bit more complicated than necessary. Please see my review comment: https://github.com/matomo-org/plugin-QueuedTracking/pull/262/files#r1798722794

[haristku]

Looks pretty good. I only had one suggested change. Sadly, I don't have a clustered environment to test with.

if you want to consider to test the clustered redis, simply:

1. download it from here
2. extract it
3. change directory to utils/create-cluster
4. run the command ./create-cluster create
5. "once" created, we just need to start it with this command ./create-cluster start
6. ./create-cluster stop to stop the cluster, and we can restart it without having to recreate it

the cluster master will bind on 127.0.0.1:30001, 127.0.0.1:30002, 127.0.0.1:30003.

if we want to change the port, run this echo "PORT=7000" > config.sh, make sure to stop the cluster, recreate & start.

and in the matomo web settings we can input:
Cluster in "Redis Type" section,
127.0.0.1,127.0.0.1,127.0.0.1 in "Redis host or unix socket" section,
30001,30002,30003 in "Redis port" section,

ty.

[haristku]

@AltamashShaikh @snake14

config migration done..
ty.

[snake14]

Everything looks good 👍 I tested the migration, but I haven't had a chance to test with a cluster yet.

[AltamashShaikh]

This has good amount of changes, will release v5.1.0 of the plugin and update the migration script accordingly.

@haristku Thank you very much for all of your contributions :)

[haristku]

@AltamashShaikh @snake14

you're welcome, i'm happy to be able to contribute. hopefully it can be useful. 👍