Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow private repos pulls #234

Merged
merged 2 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ SPRINT_SIZE_BLOCK_NUMBER=0 # comma separated values defining the block heights o
BLOCK_NUMBER=0 # comma separated values defining the block heights of bor where block time must change
BLOCK_TIME=2 # comma separated values defining the block times for the relative BLOCK_NUMBERs
BOR_REPO="https://github.com/maticnetwork/bor.git" # repo of bor project
# BOR_REPO="https://<username>:<token>@github.com/<username>/<repo>.git" # example of private repo URL
BOR_BRANCH=develop # bor branch defining the version to be used in the devnet
ERIGON_REPO="https://github.com/ledgerwatch/erigon.git" # repo of Erigon project
ERIGON_BRANCH=main # Erigon branch defining the version to be used in the devnet
Expand Down
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,11 @@ The `express-cli` also comes with additional utility commands, listed below. Som
- `../../bin/express-cli.js --fund-ganache-accounts`
- Transfers 10 eth to all the ganache accounts.

Note: to allow `express-cli` to clone private repos, make sure the git configs in the `.env` file looks like the following (example for `BOR_REPO`)
```shell
# BOR_REPO="https://<username>:<token>@github.com/<username>/<repo>.git" # example of private repo URL
```

## `Milestone tests`

The `express-cli` can also be used to perform few simulation based tests for the upcoming milestone feature. Please refer to the steps and requirements mentioned over [here](./docs/milestones.md) for running the tests.
Expand Down
12 changes: 6 additions & 6 deletions src/express/common/config-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -206,27 +206,27 @@ function validateEnvVars(cloud) {
BLOCK_NUMBER: validStr({ default: '0,64' }),
BLOCK_TIME: validStr({ default: '3,2' }),
DEVNET_BOR_FLAGS: validStr({ default: 'config,cli' }),
BOR_REPO: url({
BOR_REPO: validStr({
default: 'https://github.com/maticnetwork/bor.git'
}),
BOR_BRANCH: validStr({ default: 'develop' }),
ERIGON_REPO: url({
ERIGON_REPO: validStr({
default: 'https://github.com/ledgerwatch/erigon.git'
}),
ERIGON_BRANCH: validStr({ default: 'main' }),
HEIMDALL_REPO: url({
HEIMDALL_REPO: validStr({
default: 'https://github.com/maticnetwork/heimdall.git'
}),
HEIMDALL_BRANCH: validStr({ default: 'develop' }),
CONTRACTS_REPO: url({
CONTRACTS_REPO: validStr({
default: 'https://github.com/maticnetwork/contracts.git'
}),
CONTRACTS_BRANCH: validStr({ default: 'master' }),
GENESIS_CONTRACTS_REPO: url({
GENESIS_CONTRACTS_REPO: validStr({
default: 'https://github.com/maticnetwork/genesis-contracts.git'
}),
GENESIS_CONTRACTS_BRANCH: validStr({ default: 'master' }),
MATIC_CLI_REPO: url({
MATIC_CLI_REPO: validStr({
default: 'https://github.com/maticnetwork/matic-cli.git'
}),
MATIC_CLI_BRANCH: validStr({ default: 'master' }),
Expand Down
Loading