Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exit on services not running or not configured #194

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

marcello33
Copy link
Contributor

Description

In this PR, we fix the behaviour of express-cli to avoid process.exit when the services (bor, heimdall or erigon) are not running or are not configured on the VMs.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 requested a review from a team August 10, 2023 08:58
@marcello33 marcello33 merged commit 190e07f into master Aug 10, 2023
3 checks passed
@marcello33 marcello33 deleted the mardizzone/fix-start-stop-aws-instances branch November 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants