Update webpack configuration to downcompile SRE so es5 directory really is es5. (#899) #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
reviewed
Mar 3, 2023
|
Looks like the next version of SRE is not going to be able to be down compiled to ES5, so I'm marking this as a draft for now. We discussed making two versions of MathJax, and ES5 and ES6, so we can either go with only ES6, or have the ES5 not be fully ES5 (not too good), or have the ES5 version NOT include SRE by default. |
|
Closing this, as the new ES6/ES5 configuration makes it unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current combined components in the
es5directory include SRE as is, which is ES6 (it includesclassdeclarations and such), so the results are not actually ES5. This PR changes thewebpack.common.jsto force SRE to be down compiled, and add the needed regenerator-runtime library to make it work. This makes the resulting files larger, but does make them actual ES5 files.Resolves issue #899.