Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change color automatic #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VINAYSH778
Copy link

No description provided.

Copy link
Owner

@matheusgomes28 matheusgomes28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change! There is a bit of noise in this PR, however. I've pointed out what stuff you can remove or undo 👍

# Main entry point
# """
# grid = GOSPER_GLIDER

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could remove these commented lines :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(: yea

@@ -15,22 +106,20 @@


def get_neighbours(grid: Grid, x: int, y: int) -> Neighbours:
"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back the documentation and update where you've changed the functions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok thanku so much for guid

"""
Given a grid, this function returns the next iteration
of the game of life.
of the game of life.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra spaces after the last char

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but unnoticeable.

@@ -45,21 +134,18 @@ def update_grid(grid: Grid) -> Grid:
new_cells.add((pos[0], pos[1]))

return Grid(grid.dim, new_cells)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these new lines aren't needed here? Unless you think the previous code was unreadable without them 😄

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheusgomes28 Just helps cleanliness.

@@ -1,7 +1,98 @@
"""
Pygame of life module. Contains the short engine
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the docstring here unchanged

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just worked w/ that file

@matheusgomes28
Copy link
Owner

Hey @VINAYSH778 , I still can't see the changes from the suggested comments! After you push them ping me and I'll merge this :)

@kailando
Copy link

Hey VINAYSH778 , I still can't see the changes from the suggested comments! After you push them ping me and I'll merge this :)

@matheusgomes28 I think mods can edit...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants