-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change color automatic #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change! There is a bit of noise in this PR, however. I've pointed out what stuff you can remove or undo 👍
# Main entry point | ||
# """ | ||
# grid = GOSPER_GLIDER | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could remove these commented lines :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(: yea
@@ -15,22 +106,20 @@ | |||
|
|||
|
|||
def get_neighbours(grid: Grid, x: int, y: int) -> Neighbours: | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add back the documentation and update where you've changed the functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok ok thanku so much for guid
""" | ||
Given a grid, this function returns the next iteration | ||
of the game of life. | ||
of the game of life. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra spaces after the last char
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but unnoticeable.
@@ -45,21 +134,18 @@ def update_grid(grid: Grid) -> Grid: | |||
new_cells.add((pos[0], pos[1])) | |||
|
|||
return Grid(grid.dim, new_cells) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe these new lines aren't needed here? Unless you think the previous code was unreadable without them 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matheusgomes28 Just helps cleanliness.
@@ -1,7 +1,98 @@ | |||
""" | |||
Pygame of life module. Contains the short engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave the docstring here unchanged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just worked w/ that file
Hey @VINAYSH778 , I still can't see the changes from the suggested comments! After you push them ping me and I'll merge this :) |
@matheusgomes28 I think mods can edit...? |
No description provided.