Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the definition of mmorphism following math-comp/math-comp#1296 #93

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Draft

Fix the definition of mmorphism following math-comp/math-comp#1296 #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/monalg.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
From mathcomp Require Import seq path choice finset fintype finfun.
From mathcomp Require Import tuple bigop ssralg ssrint ssrnum.

Require Import xfinmap.

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset _ | _ : _ in _ ]" defined at level 0

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset _ | _ in _ ]" defined at level 0 with arguments

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset[ _ ] _ | _ : _ in _ ]" defined at level 0

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset[ _ ] _ | _ in _ ]" defined at level 0

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset _ | _ : _ in _ ]" defined at level 0

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset _ | _ in _ ]" defined at level 0 with arguments

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset[ _ ] _ | _ : _ in _ ]" defined at level 0

Check warning on line 13 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-dev) 

Notations "[ fset[ _ ] _ | _ in _ ]" defined at level 0

Set Implicit Arguments.
Unset Strict Implicit.
Expand Down Expand Up @@ -127,8 +127,8 @@
Export Exports.

(* -------------------------------------------------------------------- *)
Definition mmorphism (M : monomType) (S : ringType) (f : M -> S) :=
{morph f : x y / (x * y)%M >-> (x * y)%R} * (f 1%M = 1) : Prop.
Definition mmorphism (M : monomType) (S : ringType) (f : M -> S) : Prop :=
(f 1%M = 1) * {morph f : x y / (x * y)%M >-> (x * y)%R}.

HB.mixin Record isMultiplicative
(M : monomType) (S : ringType) (apply : M -> S) := {
Expand All @@ -155,10 +155,10 @@
Variables (M : monomType) (S : ringType) (f : {mmorphism M -> S}).

Lemma mmorph1 : f 1%M = 1.
Proof. exact: mmorphism_subproof.2. Qed.
Proof. exact: mmorphism_subproof.1. Qed.

Lemma mmorphM : {morph f : x y / (x * y)%M >-> (x * y)%R}.
Proof. exact: mmorphism_subproof.1. Qed.
Proof. exact: mmorphism_subproof.2. Qed.
End MMorphismTheory.

(* -------------------------------------------------------------------- *)
Expand Down Expand Up @@ -198,10 +198,10 @@

End MalgBaseOp.

Arguments mcoeff {K G} x%monom_scope g%ring_scope.

Check warning on line 201 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 201 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp:2.2.0-coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 201 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp:2.2.0-coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 201 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use
Arguments mkmalg {K G} _.
Arguments mkmalgU {K G} k%monom_scope x%ring_scope.

Check warning on line 203 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 203 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp:2.2.0-coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 203 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp:2.2.0-coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 203 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use
Arguments msupp {K G} g%ring_scope.

Check warning on line 204 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 204 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp:2.2.0-coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 204 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp:2.2.0-coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

Check warning on line 204 in src/monalg.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp-dev:coq-8.19) 

The '%' scope delimiter in 'Arguments' commands is deprecated, use

(* -------------------------------------------------------------------- *)
Notation "g @_ k" := (mcoeff k g).
Expand Down
Loading