Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerated Analysis #1441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Accelerated Analysis #1441

wants to merge 1 commit into from

Conversation

Tragicus
Copy link
Collaborator

Motivation for this change

There are a few lines that take a long time to compile (up to 12s). This PR takes every line that takes above 1s to compile and that is not an import or an HB command and rewrites it in less than a second (when I could). This saves overall 7% of the compilation time (with most of the time save (-29%) in lebesgue_integral.v).

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@Tragicus
Copy link
Collaborator Author

Tragicus commented Dec 19, 2024

@CohenCyril mentioned that integral should probably be locked. I tried something but did not observe any time save on the slow lines a was looking at (the set of which is obviously not empty), so I gave up.
EDIT: I think I am misremembering and it is funpos and funneg that I was supposed to lock, otherwise the unification of \int[mu]_(x in D) f1^\+ x with \int[mu]_(x in D) f1^\- x obviously goes under the lock.

@Tragicus
Copy link
Collaborator Author

I am not convinced that we want all the changes, I can add the time saved be each change if this helps the decision making.

@Tragicus Tragicus changed the title perf patch lebesgue_integral.v Analyse faster Dec 19, 2024
@Tragicus
Copy link
Collaborator Author

Fun fact: ~16% of the total compilation time is spent on HB commands and ~27% is spent importing things.

@Tragicus Tragicus changed the title Analyse faster Accelerated Analysis Dec 20, 2024
@affeldt-aist affeldt-aist self-requested a review December 20, 2024 13:34
@affeldt-aist affeldt-aist added this to the 1.9.0 milestone Dec 20, 2024
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants