Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace some `|Num.floor _|%N with Num.trunc _ #1432

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

replace some `|Num.floor _|%N with Num.trunc _ #1432

wants to merge 1 commit into from

Conversation

pi8027
Copy link
Member

@pi8027 pi8027 commented Dec 7, 2024 •
edited
Loading

Motivation for this change

#1244 (comment)

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@pi8027 pi8027 changed the title replace some `|Num.floor _| with Num.trunc _ replace some `|Num.floor _|%N with Num.trunc _ Dec 7, 2024
@affeldt-aist affeldt-aist self-requested a review December 9, 2024 04:38
affeldt-aist
affeldt-aist approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the lemma to the changelog and we are good to go.

@pi8027
Copy link
Member Author

pi8027 commented Dec 9, 2024

Please merge #1415 first.

@pi8027 pi8027 marked this pull request as draft December 9, 2024 09:24
@pi8027 pi8027 force-pushed the norm_floor_trunc branch 2 times, most recently from 3f962ed to a1d8a8f Compare December 10, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@affeldt-aist affeldt-aist affeldt-aist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pi8027 @affeldt-aist