-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional arg deadline
to dev.deprecated
to raise warning after deadline
#631
Changes from 13 commits
36131f7
05d77e0
a51fb8d
2956082
a39ca06
4bdc371
2088f8d
cb91417
e97cfe9
783a982
d5b463b
5cca0dc
2901b9d
bb4af84
59458a2
a37e12c
0a13730
a247764
247b297
5d62012
80bfea5
de31119
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -328,7 +328,7 @@ def __get_pydantic_core_schema__(cls, source_type, handler): | |
if core_schema is None: | ||
raise RuntimeError("Pydantic >= 2.0 is required for validation") | ||
|
||
s = core_schema.general_plain_validator_function(cls.validate_monty_v2) | ||
s = core_schema.with_info_plain_validator_function(cls.validate_monty_v2) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replaced from: test_json.py::TestJson::test_pydantic_integrations
/home/yang/Developers/monty/monty/json.py:331: DeprecationWarning: `general_plain_validator_function` is deprecated, use `with_info_plain_validator_function` instead.
s = core_schema.general_plain_validator_function(cls.validate_monty_v2) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should fix #598. |
||
|
||
return core_schema.json_or_python_schema(json_schema=s, python_schema=s) | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,9 @@ | ||
pytest | ||
pytest-cov | ||
coverage | ||
coveralls | ||
pycodestyle | ||
mypy | ||
pydocstyle | ||
pydantic | ||
flake8 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me know if they're still needed anywhere. Thanks! |
||
black | ||
pylint | ||
torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the docs automatically generated? It seems this method doesn't exist anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the docs are auto-generated from doc strings. possible that this needs to be rerun @shyuep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the input.