Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

add a convertion step before GraphCrystalDisordered training #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liuxiaotong15
Copy link

Signed-off-by: xiaotong.liu [email protected]

fix the GraphCrystalDisordered atom_converter issue

@chc273
Copy link
Contributor

chc273 commented Dec 25, 2021

@liuxiaotong15 thanks for the contribution. However, I think this is not the optimal way to do it since in every batch you constructed a new CrystalGraphDisordered. I will think about this more

@liuxiaotong15
Copy link
Author

@liuxiaotong15 thanks for the contribution. However, I think this is not the optimal way to do it since in every batch you constructed a new CrystalGraphDisordered. I will think about this more

@chc273 Only once. Then the type will be change from 'collections.defaultdict' to 'list'.
yes, wish you have a better place to insert these convertion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants