Use binary distribution (wheels) to install pymatgen in test suite #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
DanielYang59
changed the title
.whl) before release to PyPI.whl) distributions before release to PyPI
DanielYang59
force-pushed
the
test-sdist-whl-before-release
branch
2 times, most recently
from
7f5bacd
to
d262527
Compare
DanielYang59
force-pushed
the
test-sdist-whl-before-release
branch
from
d262527
to
0eb4d0c
Compare
DanielYang59
force-pushed
the
test-sdist-whl-before-release
branch
from
2440b81
to
5dc1b25
Compare
DanielYang59
changed the title
.whl) distributions before release to PyPI
DanielYang59
changed the title
DanielYang59
commented
Oct 13, 2024
DanielYang59
force-pushed
the
test-sdist-whl-before-release
branch
from
5b862e2
to
c9f995f
Compare
DanielYang59
force-pushed
the
test-sdist-whl-before-release
branch
from
de5088e
to
0dba028
Compare
…I failure" This reverts commit 0dba028.
DanielYang59
changed the title
DanielYang59
force-pushed
the
test-sdist-whl-before-release
branch
from
394dd50
to
17b1acf
Compare
…nielYang59/pymatgen into test-sdist-whl-before-release
DanielYang59
force-pushed
the
test-sdist-whl-before-release
branch
from
02868df
to
8d11d91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pymatgenin test suite, currently neither source distribution nor binary distribution is tested against test suite, might lead to breakage if we miss anything from them (heard this happened before). The reason to use binary distribution over source distribution is the former is what at the end of day being installed on a user's machine: