Adding Dask support to mrun #927
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -214,6 +286,18 @@ | |||
| ) | |||
| else: | |||
| worker(url=url, port=port, num_processes=num_processes, no_bars=no_bars) | |||
| elif dask: | |||
| dask_executor( | |||
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
==========================================
- Coverage 81.56% 80.58% -0.99%
==========================================
Files 46 47 +1
Lines 3938 4007 +69
==========================================
+ Hits 3212 3229 +17
- Misses 726 778 +52 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
added a Dask work broker for use with mrun
Todos
Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.