Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ChemRxiv citation #1107

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

hrushikesh-s
Copy link
Collaborator

No description provided.

@hrushikesh-s hrushikesh-s requested a review from janosh January 22, 2025 22:05
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update citation.cff which controls the "Cite this repo" button in the GitHub side bar

@janosh janosh added the docs Improvements or additions to documentation label Jan 22, 2025
@hrushikesh-s
Copy link
Collaborator Author

@janosh , updated the citation.cff!

@hrushikesh-s
Copy link
Collaborator Author

@janosh , do you know why the test in failing?

@janosh
Copy link
Member

janosh commented Jan 23, 2025

not sure, sounds like some breaking upstream change in abinit:

assert diffs == [], "'run.abi' is different from reference."
       ^^^^^^^^^^^
AssertionError: 'run.abi' is different from reference.

would be good to print diffs in that error message. maybe @gbrunin is more in sync with abinit development and can offer some pointers

@JaGeo
Copy link
Member

JaGeo commented Jan 23, 2025

Hey both, please check out #1106 . We are working on a fix.

@hrushikesh-s
Copy link
Collaborator Author

@janosh , we cant merge the changes of this PR in main until the tests pass, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrushikesh-s do you mind if we just inline this file into readme? not used elsewhere so adds clutter to the repo's root directory

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, that's perfectly fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janosh I am not sure I fully get this comment. I would otherwise merge as the failing tests are now passing. Maybe, you can have a short look and make the required changes?

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaGeo tests are still failing on main so i'll force merge this PR

@janosh janosh merged commit edbd0b1 into materialsproject:main Jan 23, 2025
14 checks passed
@janosh
Copy link
Member

janosh commented Jan 23, 2025

my bad, looks like tests are passing on main. only the docs are failing due to use of outdated actions/upload-artifact@3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants