-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ChemRxiv citation #1107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also update citation.cff
which controls the "Cite this repo" button in the GitHub side bar
@janosh , updated the citation.cff! |
@janosh , do you know why the test in failing? |
not sure, sounds like some breaking upstream change in assert diffs == [], "'run.abi' is different from reference."
^^^^^^^^^^^
AssertionError: 'run.abi' is different from reference. would be good to print |
Hey both, please check out #1106 . We are working on a fix. |
@janosh , we cant merge the changes of this PR in main until the tests pass, right? |
citation_chemrxiv.bib
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hrushikesh-s do you mind if we just inline this file into readme? not used elsewhere so adds clutter to the repo's root directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, that's perfectly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janosh I am not sure I fully get this comment. I would otherwise merge as the failing tests are now passing. Maybe, you can have a short look and make the required changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JaGeo tests are still failing on main
so i'll force merge this PR
my bad, looks like tests are passing on |
No description provided.