forked from Dogfalo/materialize
-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(Timepicker) implementation with confirmation buttons util #575
Open
gselderslaghs
wants to merge
10
commits into
materializecss:v2-dev
Choose a base branch
from
gselderslaghs:timepicker-confirmation-buttons-util
base: v2-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
enhancement(Timepicker) implementation with confirmation buttons util #575
gselderslaghs
wants to merge
10
commits into
materializecss:v2-dev
from
gselderslaghs:timepicker-confirmation-buttons-util
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; configured confirmation buttons to render when auto submit is false materializecss#558
…rmation container only if auto submit is false; removed timeout since its redundant; fixed incorrect callback option check in cancel callback materializecss#570
Implemented additional check to render confirmation container only if auto submit is false (as in #572) This is ready for review |
Thanks for the awesome work! I will take a look next year and review it. Best wishes to all contributors and take care going into the new year. See you all soon ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request is a follow up of #572 and #574 and handles the implementation of the Utils.createButton with callback method and the Utils.createConfirmContainer with callback methods
With the callback function, we can open and close modal (or custom) implementation in combination with timepicker with the onDone and onCancel callbacks
Example:
html
script
Checklist: